Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use context manager when creating temporary directory #12559

Merged
merged 1 commit into from
Aug 1, 2022
Merged

Use context manager when creating temporary directory #12559

merged 1 commit into from
Aug 1, 2022

Conversation

fridex
Copy link
Contributor

@fridex fridex commented Jul 21, 2022

What does this PR do?

With this change, the temporary directory will be removed if there would be any
exception within the with block. The temporary directory would be
properly removed on any error raised.

Use context manager when creating temporary directory in datadog-chec…
83aabcd 
…ks-downloader

With this change, the temporary directory will be removed if there would be any
exception within the with block. The temporary directory would be
properly removed on any error raised.
@fridex fridex requested a review from a team as a code owner July 21, 2022 08:07
FlorentClarret
FlorentClarret approved these changes Jul 27, 2022
View reviewed changes
Copy link
Member

@FlorentClarret FlorentClarret left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@FlorentClarret FlorentClarret merged commit 675fe0d into DataDog:master Aug 1, 2022
@fridex fridex deleted the context-manager-tmpdir branch August 1, 2022 10:31
FlorentClarret added a commit that referenced this pull request Aug 1, 2022
@FlorentClarret
Revert "Use context manager when creating temporary directory in data…
b5ded45 
…dog-checks-downloader (#12559)"

This reverts commit 675fe0d.
@FlorentClarret FlorentClarret mentioned this pull request Aug 1, 2022
Merged
4 tasks
FlorentClarret added a commit that referenced this pull request Aug 1, 2022
@FlorentClarret
Revert #12559 to make it compatible with python2 (#12647)
5673b5d 
* Revert "Use context manager when creating temporary directory in datadog-checks-downloader (#12559)"

This reverts commit 675fe0d.

* Make sure the tempdir is removed in case an exception is raised
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlorentClarret FlorentClarret FlorentClarret approved these changes

@cedricvanrompay-datadog cedricvanrompay-datadog cedricvanrompay-datadog approved these changes

Assignees
No one assigned
Labels
integration/datadog_checks_downloader
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fridex @FlorentClarret @cedricvanrompay-datadog